[PATCH] D103773: [clang-cl] Add /permissive and /permissive-
Alexandre Ganea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 15 19:26:56 PDT 2021
aganea added inline comments.
================
Comment at: clang/test/Driver/cl-permissive.c:15
+// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing"
+// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck -check-prefix=PERMISSIVE-MINUS-OVERWRITE %s
+// PERMISSIVE-MINUS-OVERWRITE-NOT: "-fno-operator-names"
----------------
Hello @zero9178 !
After this patch, the following fails:
`// RUN: %clang_cl /permissive- -- %s`
generates:
`error: error reading '/Zc:strictStrings'`
Because `/Zc:strictStrings` isn't correctly expanded to `-Werror=c++11-compat-deprecated-writable-strings` as it should, but it is passed as-is to cc1. You can put a breakpoint here: https://github.com/llvm/llvm-project/blob/fc018ebb608ee0c1239b405460e49f1835ab6175/clang/lib/Driver/ToolChains/Clang.cpp#L5374 and observe before/after this line.
Would you possibly have a chance to take a look please?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103773/new/
https://reviews.llvm.org/D103773
More information about the cfe-commits
mailing list