[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 15 13:56:35 PDT 2021


rsmith added inline comments.


================
Comment at: clang/include/clang/Basic/IdentifierTable.h:125
+  // True if this identifier is a literal operator without whitespace.
+  unsigned IsLiteralOperatorWithoutWhitespace : 1;
+
----------------
This is per-declaration state; I don't think we can reasonably store it on `IdentifierInfo`, which is global information about an identifier. This will do the wrong thing if (for example) literal operators with the same suffix but different whitespace are declared in different scopes or if the same operator is multiply declared with different whitespace in the same scope.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104299/new/

https://reviews.llvm.org/D104299



More information about the cfe-commits mailing list