[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

[David Blaikie via Phabricator via cfe-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D104082#2818281 <https://reviews.llvm.org/D104082#2818281>, @ahatanak wrote:

> C++ non-virtual thunks and global initialization functions (`_GLOBAL__sub_I_*`) have only linkage names.

Works for me - and the debug info codegen looks like it does handle this situation intentionally: https://github.com/llvm/llvm-project/blob/a11880468e556d20ad9b0d43a1ff43daf62d49b2/clang/lib/CodeGen/CGDebugInfo.cpp#L3896.

Maybe give it a few days (or directly ask) to see if @aprantl has further thoughts, since I'm not especially familiar with Objective C things, but it looks pretty right/good enough for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104082/new/

https://reviews.llvm.org/D104082