[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri updated this revision to Diff 352176.
lebedev.ri retitled this revision from "[NewPM] Remove SpeculateAroundPHIs pass from pipeline" to "[NewPM] Remove SpeculateAroundPHIs pass".
lebedev.ri added a comment.
Herald added a subscriber: mgorny.

On Tue, Jun 15, 2021 at 8:14 PM Wei Mi <wmi at google.com> wrote:

> On Mon, Jun 14, 2021 at 4:52 PM Wei Mi <wmi at google.com> wrote:
>
>> On Mon, Jun 14, 2021 at 4:04 PM Xinliang David Li <davidxl at google.com> wrote:
>>
>>> On Mon, Jun 14, 2021 at 3:59 PM Roman Lebedev via Phabricator <reviews at reviews.llvm.org> wrote:
>>>
>>>> lebedev.ri added a subscriber: MaskRay.
>>>> lebedev.ri added a comment.
>>>>
>>>> In D104099#2815531 <https://reviews.llvm.org/D104099#2815531> https://reviews.llvm.org/D104099#2815531, @wenlei wrote:
>>>>
>>>>> In D104099#2814167 <https://reviews.llvm.org/D104099#2814167> https://reviews.llvm.org/D104099#2814167, @davidxl wrote:
>>>>>
>>>>>> Adding Wei to help measure performance impact on our internal workloads.  Also add Wenlei to help measure impact with FB's workloads.
>>>>>
>>>>> Measured perf using FB internal workload w/ and w/o this pass, result is neutral.
>>>>
>>>> Thank you for checking!
>>>>
>>>> So far, it seems the reaction to this proposal has been overwhelmingly positive.
>>>> Does anyone else wish to chime in? Should i land this? @asbirlea @MaskRay ?
>>>
>>> Wei is doing more measurement @google. Please wait for the response.
>>>
>>> David
>>
>> Start doing the test. Will report back.
>>
>> Wei.
>
> No performance change found in google internal benchmarks.
>
>  Wei.

Thanks for checking.
So, so far no one can point out why this pass is beneficial? :]

How about this then?

>>  
>>
>>>> Repository:
>>>>   rG <https://reviews.llvm.org/source/llvm-github/> LLVM Github Monorepo
>>>>
>>>> CHANGES SINCE LAST ACTION
>>>>   https://reviews.llvm.org/D104099/new/
>>>>
>>>> https://reviews.llvm.org/D104099


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104099/new/

https://reviews.llvm.org/D104099

Files:
  clang/test/CodeGen/thinlto-distributed-newpm.ll
  llvm/include/llvm/Transforms/Scalar/SpeculateAroundPHIs.h
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/Scalar/CMakeLists.txt
  llvm/lib/Transforms/Scalar/SpeculateAroundPHIs.cpp
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-thinlto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Transforms/LoopUnroll/AArch64/runtime-unroll-generic.ll
  llvm/test/Transforms/PhaseOrdering/AArch64/hoisting-sinking-required-for-vectorization.ll
  llvm/test/Transforms/PhaseOrdering/loop-rotation-vs-common-code-hoisting.ll
  llvm/test/Transforms/SpeculateAroundPHIs/basic-x86.ll
  llvm/test/Transforms/SpeculateAroundPHIs/convergent.ll
  llvm/test/Transforms/SpeculateAroundPHIs/pr42991.ll
  llvm/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104099.352176.patch
Type: text/x-patch
Size: 82223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210615/bae3e13d/attachment-0001.bin>