[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Tue Jun 15 07:12:46 PDT 2021

christophe-calmejane added a comment.

In D104222#2819324 <https://reviews.llvm.org/D104222#2819324>, @Wawha wrote:

> Hi @christophe-calmejane.
> I test your code with a old version (few time after the merge of https://reviews.llvm.org/D44609), and the latest version (commit: e0c382a9d5a0 <https://reviews.llvm.org/rGe0c382a9d5a0e2689b97186736ebc82e17c5f822>), and in both cases I have the same result, which is near your output:
>
> I though I add multiples cases, but looking at UnitTests with inline lambda "None", I see only few tests, perhaps some are missing.

I posted a fix for the incorrect formatting you have in your output (in your original review post), but like I said back then, I thought the fix was not clean enough to be included. Nevertheless it did fix all cases and formatting was perfect for my whole test suite.
I using this "patched" version since then as it's the only one with the correct lambda formatting. I tried to reapply my patch on a recent version.. of course it failed as there were too many changes in clang-format. I don't have enough knowledge on this project to be able to clearly understand how it works and fix the formatting on the latest version (but I wish I could)... at least not without having to spend too much time on it :(
For the record, my patch over clang-format 7.0 can be found here: https://www.kikisoft.com/Hive/clang-format/

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104222/new/

https://reviews.llvm.org/D104222