[PATCH] D104275: [compiler-rt][hwasan] Add SHADOW_OFFSET macro

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 14 21:36:00 PDT 2021


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:57
 
 extern uptr kAliasRegionStart;
 
----------------
Maybe the following to minimize code which compiles only on limited set of platforms?

```
inline uptr GetShadowOffset() {
  return SANITIZER_FUCHSIA ? 0 : __hwasan_shadow_memory_dynamic_address;
}
```


================
Comment at: compiler-rt/lib/hwasan/hwasan_mapping.h:59
 
 inline uptr MemToShadow(uptr untagged_addr) {
+  return (untagged_addr >> kShadowScale) + SHADOW_OFFSET
----------------
> clang-tidy: error: expected ';' after return statement [clang-diagnostic-error]
please fix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104275/new/

https://reviews.llvm.org/D104275



More information about the cfe-commits mailing list