[PATCH] D104248: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp

Roland McGrath via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 14 11:28:49 PDT 2021


mcgrathr added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_linux.cpp:430
 
+void Thread::Init(uptr stack_buffer_start, uptr stack_buffer_size) {
+  CHECK_EQ(0, unique_id_);  // try to catch bad stack reuse
----------------
Most of this code can actually be reused for Fuchsia (just not necessarily in Thread::Init).
It's probably better to split it up for reuse rather than just moving the whole thing to linux-specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104248/new/

https://reviews.llvm.org/D104248



More information about the cfe-commits mailing list