[PATCH] D104116: AMD k8 family does not support SSE4.x which are required by x86-64-v2+

[Stella Stamenova via Phabricator via cfe-commits]

stella.stamenova added a comment.

This change is generating warnings when building with clang:

  /usr/bin/clang++ -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Basic -I/mnt/vss/_work/1/s/clang/lib/Basic -I/mnt/vss/_work/1/s/clang/include -Itools/clang/include -Iinclude -I/mnt/vss/_work/1/s/llvm/include -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -fno-common -Woverloaded-virtual -Wno-nested-anon-types -g  -fno-exceptions -fno-rtti -std=c++14 -MD -MT tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/X86.cpp.o -MF tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/X86.cpp.o.d -o tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/X86.cpp.o -c /mnt/vss/_work/1/s/clang/lib/Basic/Targets/X86.cpp
  /mnt/vss/_work/1/s/clang/lib/Basic/Targets/X86.cpp:396:11: error: enumeration values 'CK_x86_64_v2', 'CK_x86_64_v3', and 'CK_x86_64_v4' not handled in switch [-Werror,-Wswitch]
    switch (CPU) {

Rather than removing the cases from the switch entirely, they should still be handled without defining k8.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104116/new/

https://reviews.llvm.org/D104116