[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added a comment.

@hans: FYI, that looks related to the immediately following D99005 <https://reviews.llvm.org/D99005>, not D99696 <https://reviews.llvm.org/D99696> specifically. I suspect that reverting D99005 <https://reviews.llvm.org/D99005> (but leaving D99696 <https://reviews.llvm.org/D99696> in trunk) would suffice to fix that symptom. But I agree I don't see why it should be happening. That block code looks reasonable to me at first glance and wasn't intended to be affected by D99005 <https://reviews.llvm.org/D99005> AFAIK.
@mizvekov: See why I'm skeptical about merging big patches back-to-back and/or on Fridays? ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99696/new/

https://reviews.llvm.org/D99696