[PATCH] D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2263-2264
 Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) {
   addHighPriorityHandler<DefaultExpressionHandler>();
+  addLowPriorityHandler<PRValueHandler>();
   // TODO: split trackExpressionValue and FindLastStoreBRVisitor into handlers
----------------
I checked this commit out, and failed to see how these low/high priority handlers work out in practice. I tried to
* Make the default handler low prio as well
* Make the PRValue high prio
* All other combinations of the those values
* Change the order of adding these handlers

No tests failed. Is there any one patch so far that demonstrates why we need this? A unit test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103630/new/

https://reviews.llvm.org/D103630