[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added inline comments.


================
Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:194
                      CompilerInstance &I, DependencyConsumer &C,
-                     std::map<std::string, std::string, std::less<>>
-                         OriginalPrebuiltModuleFiles);
+                     CompilerInvocation OriginalInvocation);
 
----------------
dexonsmith wrote:
> I wonder if it'd be better to take `CompilerInvocation&&` here. Then the caller is required to either pass `std::move` or make a deep copy at the call site, and it's perhaps more clear that there's a deep copy being made.
That's much clearer indeed. Thanks for the suggestion!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104036/new/

https://reviews.llvm.org/D104036