[PATCH] D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler

Mon Jun 14 04:16:42 PDT 2021

Szelethus added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2069-2070
+    // this point.
+    // TODO: Shouldn't we track control dependencies of every bug location,
+    // rather than only tracked expressions?
+    if (LVState->getAnalysisManager()
----------------
I recall that  reports that don't invoke trackExpressionValue were rather small in scope (usually a few LOC), and those  in particular tended to get bigger but not better. A lot of effort went into making sure we're only placing notes where we were reasonably sure they added value -- its been a while though, so a fresh look at this wouldn't hurt.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103616/new/

https://reviews.llvm.org/D103616