[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 14 01:50:01 PDT 2021


jansvoboda11 added a comment.

In D103461#2815913 <https://reviews.llvm.org/D103461#2815913>, @dexonsmith wrote:

> Okay, LGTM. (Sorry for the delay, I've been out.)
>
> In D103461#2793254 <https://reviews.llvm.org/D103461#2793254>, @jansvoboda11 wrote:
>
>> My reason for the FIXME is that we could get rid of bunch of Windows-specific logic by adjusting `CompilerInvocation` instead.
>
> Please add that motivation to the FIXME itself.

No problem, thanks for the review(s)!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103461/new/

https://reviews.llvm.org/D103461



More information about the cfe-commits mailing list