[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

Sourabh Singh Tomar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 13 21:57:47 PDT 2021


SouraVX added a comment.

In D104118#2813358 <https://reviews.llvm.org/D104118#2813358>, @stuart wrote:

> Note: there is currently no DWARF language code defined for //C++ for OpenCL//, so we must use DW_LANG_C_plus_plus* if we wish to be able to determine whether output has been generated from //C++ for OpenCL// source or from //OpenCL C// source. I have raised DWARF issue 210514.1 <http://dwarfstd.org/ShowIssue.php?issue=210514.1> to add a dedicated //C++ for OpenCL// code in the next version of DWARF, but for now I believe that it is best to use DW_LANG_OpenCL for //OpenCL C// only, and not for //C++ for OpenCL//.
>
> I could perhaps add a note regarding this to the commit message but am concerned about overcomplicating the message.

NIT: It would be nice to have this as part of the commit summary/message itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104118/new/

https://reviews.llvm.org/D104118



More information about the cfe-commits mailing list