[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

Fri Jun 11 11:49:58 PDT 2021

dblaikie added a comment.

In D104082#2812088 <https://reviews.llvm.org/D104082#2812088>, @ahatanak wrote:

> Also, is it okay to emit the `linkageName`, but not the `name` for the helper functions? It seems okay to me, but I'm not sure.

Not 100% sure - perhaps @aprantl can weigh in on this. If you can find some precedent/existing cases where we do that, might help provide some confidence (one way I'd do that would be to put an assertion in the CGDebugInfo code that makes the choice about which names to add - asserting if only a linkage name is added and no non-linkage name - then run check-clang and see what, if any, tests fail - that'll identify cases that have this property)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104082/new/

https://reviews.llvm.org/D104082