[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

Fri Jun 11 06:27:18 PDT 2021

bjope added inline comments.

================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1449
-  // inserting redundancies into the program. This even includes SimplifyCFG.
-  OptimizePM.addPass(SpeculateAroundPHIsPass());
-
----------------
lebedev.ri wrote:
> nikic wrote:
> > As it has been in-tree for a while, I think it would be good to add a cl::opt option for people who have come to rely on it being present in some way.
> I'm not convinced that the pass can be returned into it's current position in pipeline,
> that is why the diff is what it is now.
> 
Yes, there is a contradiction between the code comment and the position in the pipeline. I did question that here: https://bugs.llvm.org/show_bug.cgi?id=48821#c2

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104099/new/

https://reviews.llvm.org/D104099