[PATCH] D103917: [analyzer] Extract InterestingLValueHandler

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2156
 
-class DefaultExpressionHandler final : public ExpressionHandler {
+// TODO: extract it into more handlers
+class InterestingLValueHandler final : public ExpressionHandler {
----------------
I honestly think this code has much bigger problems than that. This code (together with whatever remains in the default handler) is basically what encouraged me to come up with note tags; it's a prime example of a clumsy reverse engineering effort that could be communicated directly instead. Whoever untangles this will forever be ingrained in the history of the static analyzer :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103917/new/

https://reviews.llvm.org/D103917