[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2047
+
+    // TODO: get rid of it.
+    const DeclStmt *DS = nullptr;
----------------
WDYM?

Also maybe downscope it?


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2063
+                                         : "Captured by block as ";
+      showBRDiagnostics(Action, OS, SI.Dest, SI.Value, SI.Origin, DS);
+      break;
----------------
Isn't `DS` always null here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103644/new/

https://reviews.llvm.org/D103644