[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 10 12:52:42 PDT 2021


HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.

In D99840#2718959 <https://reviews.llvm.org/D99840#2718959>, @curdeius wrote:

> LGTM. I also consider it a bug. LLVM should not be affected as it uses `AllowShortEnumsOnASingleLine: true` whereas this problem arises only with `AllowShortEnumsOnASingleLine: false`.
> Anyway, those that find the new behaviour problematic, can always set `BreakBeforeBraces: Custom` and `BraceWrapping.AfterEnum: true` to get the old behaviour.
> @lunasorcery, please update release notes before landing.
> If you don't have commit rights, please provide "Your Name <email at address>" for commit attribution, otherwise we'll use the name/email associated with you Phabricator account.

What he says.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99840/new/

https://reviews.llvm.org/D99840



More information about the cfe-commits mailing list