[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

[Abhinav Gaba via Phabricator via cfe-commits]

abhinavgaba added inline comments.


================
Comment at: clang/test/AST/ast-dump-implicit-members.clcpp:10
+
+// CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept'
+// CHECK: CXXConstructorDecl {{.*}} implicit constexpr S 'void (const __generic S &) __generic'
----------------
olestrohm wrote:
> abhinavgaba wrote:
> > Could you please relax these checks? The test fails with `-triple i386-pc-win32`  with errors like this:
> > ```
> > ast-dump-implicit-members.clcpp:10:11: error: CHECK: expected string not found in input
> > // CHECK: CXXConstructorDecl {{.*}} implicit used constexpr S 'void () __generic noexcept'
> >           ^
> > <stdin>:1:1: note: scanning from here
> > Dumping __NSConstantString:
> > ^
> > <stdin>:16:18: note: possible intended match here
> > |-CXXConstructorDecl 0x10b6c718 <col:8> col:8 implicit used constexpr S 'void () __attribute__((thiscall)) __generic noexcept' inline default trivial
> >                  ^
> > ```
> Hi, sorry for this.
> I have relaxed the tests in rGac677e69bdfc, so hopefully that should fix it.
Thanks for the fix, @olestrohm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103252/new/

https://reviews.llvm.org/D103252