[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

[Andrey Churbanov via Phabricator via cfe-commits]

AndreyChurbanov added inline comments.


================
Comment at: openmp/runtime/src/kmp_taskdeps.cpp:418
     if (dep_list[i].base_addr != 0) {
+      KMP_DEBUG_ASSERT(
+          dep_list[i].flag == KMP_DEP_IN || dep_list[i].flag == KMP_DEP_OUT ||
----------------
protze.joachim wrote:
> I hit this assertion, when compiling the tests with clang-11. Is this expected behavior? Does this patch break backwards compatibility, or should this assertion just not look at the higher bits, as they might be uninitialized?
> 
> Whey I change `dep_list[i].flag` to `(dep_list[i].flag&0xf)`, the assertion doesn't trigger.
Thanks for pointing this out. I've reverted the patch in order to fix backwards compatibility problem. Will eliminate the dependence flag type size change in clang, and change the size in the library code instead.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97085/new/

https://reviews.llvm.org/D97085