[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

Thu Jun 10 06:44:14 PDT 2021

xbolva00 added inline comments.

================
Comment at: clang/docs/UsersManual.rst:1501

-   * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``).  This is the default behavior.
+   * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=on``).  This is the default behavior.
    * ``strict`` Enables ``-frounding-math`` and ``-ffp-exception-behavior=strict``, and disables contractions (FMA).  All of the ``-ffast-math`` enablements are disabled. Enables ``STDC FENV_ACCESS``: by default ``FENV_ACCESS`` is disabled. This option setting behaves as though ``#pragma STDC FENV_ACESS ON`` appeared at the top of the source file.
----------------
mibintc wrote:
> xbolva00 wrote:
> > Maybe you should add short info to Release Notes as well?
> > Maybe you should add short info to Release Notes as well?
> 
> Good idea thanks. Can I do that in a separate patch?
Yes, maybe wait a few days in case of the revert of this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74436/new/

https://reviews.llvm.org/D74436