[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

Ivan Murashko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 10 04:48:15 PDT 2021


ivanmurashko created this revision.
ivanmurashko added reviewers: aaron.ballman, alexfh, DmitryPolukhin.
ivanmurashko added projects: clang, clang-tools-extra.
Herald added a subscriber: xazax.hun.
ivanmurashko requested review of this revision.
Herald added a subscriber: cfe-commits.

There is a followup fix for a unit test introduced at D102906 <https://reviews.llvm.org/D102906>. The test file was placed into a temp folder and test assumed that it would be visible without the full path specification.

This behaviour can be changed in future and it would be good to specify full path to the file at the test.

Test Plan:

  ninja check-clang-tools


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104021

Files:
  clang-tools-extra/test/clang-tidy/infrastructure/remarks.cpp


Index: clang-tools-extra/test/clang-tidy/infrastructure/remarks.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/infrastructure/remarks.cpp
+++ clang-tools-extra/test/clang-tidy/infrastructure/remarks.cpp
@@ -2,14 +2,13 @@
 // RUN: cp -r %S/Inputs/remarks %t
 // RUN: cp %s %t/t.cpp
 
-// RUN: clang-tidy -checks='-*,modernize-use-override,clang-diagnostic-module-import' t.cpp -- \
+// RUN: clang-tidy -checks='-*,modernize-use-override,clang-diagnostic-module-import' %t/t.cpp -- \
 // RUN:     -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache \
 // RUN:     -fsyntax-only \
 // RUN:     -I%S/Inputs/remarks \
 // RUN:     -working-directory=%t \
-// RUN:     -Rmodule-build -Rmodule-import t.cpp 2>&1 |\
+// RUN:     -Rmodule-build -Rmodule-import 2>&1 |\
 // RUN: FileCheck %s -implicit-check-not "remark:"
 
 #include "A.h"
 // CHECK: remark: importing module 'A' from {{.*}} [clang-diagnostic-module-import]
-


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104021.351133.patch
Type: text/x-patch
Size: 991 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210610/cc70b688/attachment.bin>


More information about the cfe-commits mailing list