[PATCH] D103995: [OpenMP] Add type to firstprivate symbol for const firstprivate values

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 9 17:07:41 PDT 2021


jhuber6 added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10598
+    CGM.getCXXABI().getMangleContext().mangleTypeName(VD->getType(), OS);
+    OS << "_" << VD->getName() << "_l" << Line;
     VarName = OS.str();
----------------
jdoerfert wrote:
> What if the code is not C++?
Should work fine, this just mangles it according to the C++ ABI but doesn't require it being C++ as far as I know. Testing it with a sample C file creates the same symbol name as the C++ version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103995/new/

https://reviews.llvm.org/D103995



More information about the cfe-commits mailing list