[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Wed Jun 9 14:04:33 PDT 2021

mizvekov added a comment.

In D99696#2808592 <https://reviews.llvm.org/D99696#2808592>, @Quuxplusone wrote:

> @mizvekov, my understanding is:
>
> - D99696 <https://reviews.llvm.org/D99696> was temporarily blocked on D103720 <https://reviews.llvm.org/D103720>, but now D103720 <https://reviews.llvm.org/D103720> is landed and D99696 <https://reviews.llvm.org/D99696> is unblocked
> - D99696 <https://reviews.llvm.org/D99696> is a codegen improvement in all language modes, and is also blocking D99005 <https://reviews.llvm.org/D99005>
> - D99005 <https://reviews.llvm.org/D99005> is blocking our getting experience with p2266 <https://wg21.link/p2266> for C++23
>
> IMHO we should just plow ahead here. @aaronpuchert what's your take on D99696 <https://reviews.llvm.org/D99696> at this point; is it good to go or still unresolved issues?

No, actually, D99696 <https://reviews.llvm.org/D99696> (This DR) was not blocked on any other DRs, I just put it as parent here for my convenience, since I had them all stacked on my workstation to make my life easier.
Sorry if that caused confusion and anyone thought it was blocked....

D99005 <https://reviews.llvm.org/D99005> (The P2266 <https://reviews.llvm.org/P2266> implementation) is blocked just on the present DR, but that was because there are common changes and I decided to do them in this order since it was not clear when P2266 <https://reviews.llvm.org/P2266> impl could be merged.

D103720 <https://reviews.llvm.org/D103720> was a dependency for D100733 <https://reviews.llvm.org/D100733> proposed by @rsmith, which is a dependency of D100000 <https://reviews.llvm.org/D100000> (This is the one that implements the 'almost xvalue' thing that Jason Merril was pushing on the reflector, in order to replace the two-phase overload resolution).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99696/new/

https://reviews.llvm.org/D99696