[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 9 07:15:57 PDT 2021


jdoerfert added a comment.

Thanks for splitting this. I quickly went over it only.



================
Comment at: clang/docs/ClangOffloadBundler.rst:137
+
+  myarch--myOS-
 
----------------
not needed here.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:1431
+               ? UnbundleArchive()
+               : Unbundle ? UnbundleFiles() : BundleFiles();
+  });
----------------
By now, a proper conditional seems appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93525/new/

https://reviews.llvm.org/D93525



More information about the cfe-commits mailing list