[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 8 22:18:23 PDT 2021
MaskRay added a comment.
How do the new tests provide additional coverage?
================
Comment at: clang/test/Driver/riscv-arch.c:45
+
+// CHECK-ILP32: "-target-feature" "+m"
+// CHECK-ILP32-SAME: "-target-feature" "+f"
----------------
I suggest the style used in linux-cross.cpp
Just using `-SAME` cannot detect unrelated strings between "-target-feature" "+m" and "-target-feature" "+f"
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103878/new/
https://reviews.llvm.org/D103878
More information about the cfe-commits
mailing list