[PATCH] D103564: [NFC][compiler-rt][hwasan] Move allocation functions into their own file
Leonard Chan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 8 12:07:13 PDT 2021
leonardchan added inline comments.
================
Comment at: compiler-rt/lib/hwasan/hwasan_interceptors.cpp:171
} // namespace __hwasan
+#else // #if !SANITIZER_FUCHSIA
+namespace __hwasan {
----------------
vitalybuka wrote:
> mcgrathr wrote:
> > blank lines around `#else` and `#endif` lines. But here I think you just omit this. We can define the empty function in a fuchsia-specific file.
> >
> +1 to "empty function in a fuchsia-specific file"
Will add in an eventual `hwasan_fuchsia.cpp`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103564/new/
https://reviews.llvm.org/D103564
More information about the cfe-commits
mailing list