[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 8 12:01:28 PDT 2021


leonardchan added a comment.

In D103845#2804441 <https://reviews.llvm.org/D103845#2804441>, @pcc wrote:

> This isn't how the output looks on Android. Are you sure this isn't a Fuchsia-specific bug in the output formatting?

I think the newline gets added to the frame description only if `Symbolizer::GetOrInit()->SymbolizePC(pc)` is nonnull, so if it fails then no newline is added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103845/new/

https://reviews.llvm.org/D103845



More information about the cfe-commits mailing list