[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

Tue Jun 8 08:42:57 PDT 2021

MyDeveloperDay added inline comments.

================
Comment at: clang/unittests/Format/FormatTest.cpp:8283-8286
+  // TODO:
+  // Calling an operator as a non-member function is hard to distinguish
+  // verifyFormat("void f() { operator*(a & a); }");
+  // verifyFormat("void f() { operator&(a, b * b); }");
----------------
curdeius wrote:
> curdeius wrote:
> > Nuullll wrote:
> > > This patch doesn't fix these, i.e. when operators are called as non-member functions.
> > > The call sites seem to be marked as function declarations.
> > Is there a bug report on that? If so, please add a link to the comment. If no, could you please create one?
> > Or is it really something that will never be possible to distinguish (hmm, this would be strange)?
> Nit: full-stop.
Might be nice just to fix these as well, this is kind of what happens with clang-format development... you fix one thing we try to make you fix everything else around it, otherwise who is going to understand it better than you! ;-)

We do appreciate your patch!!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103678/new/

https://reviews.llvm.org/D103678