[PATCH] D103797: [clang] Use resolved path for headers in decluse diagnostics
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 7 08:21:04 PDT 2021
sammccall added a subscriber: rsmith.
sammccall added a comment.
This seems sensible to me but hard to know if it's going to be an improvement in practice. Can you paste a realistic example?
@rsmith any opinion about this diag?
================
Comment at: clang/test/Modules/declare-use1.cpp:6
#include "e.h"
-#include "f.h" // expected-error {{module XG does not depend on a module exporting 'f.h'}}
+#include "f.h" // expected-error-re {{module XG does not depend on a module exporting '{{.*}}{{/|\\}}f.h'}}
#include "i.h"
----------------
I'd be tempted to leave the slashes in the globs for readability
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103797/new/
https://reviews.llvm.org/D103797
More information about the cfe-commits
mailing list