[PATCH] D103605: [analyzer] Introduce a new interface for tracking

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:147
+class ExpressionHandler;
+class StoreHandler;
+
----------------
vsavchenko wrote:
> xazax.hun wrote:
> > During path sensitive analysis we already have a callback for stores. We kind of replicating this logic for bug paths. 
> > So my questions are:
> > * Do we expect to have additional information here that were not available during the analysis earlier?
> > * Do we want to make this as similar to the forward analysis part as possible for developer familiarity?
> Oof, I actually think that this one is trickier.  If the checker modeled some operation (most likely `evalCall`), it can bind a value to the region by itself.  And this handler triggers for such events as well because it simply finds the place where the switch was flipped and the region changed its binding.
> If the checker modeled some operation (most likely evalCall), it can bind a value to the region by itself. And this handler triggers for such events as well because it simply finds the place where the switch was flipped and the region changed its binding.

This is such a great point, I'd like that to be captured as a comment somewhere. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103605/new/

https://reviews.llvm.org/D103605