[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 4 15:46:26 PDT 2021


sbc100 added inline comments.


================
Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68
+// NEG-NOT: @_ZL13var_host_only
+// NEG-NOT: external
 
----------------
This seems to break if the pathname where the llvm checkout lives contains the word "external"

https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8845343598940893760/+/steps/LLVM_regression/0/stdout

```
--
/b/s/w/ir/cache/builder/emscripten-releases/llvm-project/clang/test/CodeGenCUDA/device-use-host-var.cu:68:13: error: NEG-NOT: excluded string found in input
// NEG-NOT: external
            ^
<stdin>:69:78: note: found here
!1 = !{!"clang version 13.0.0 (/b/s/w/ir/cache/git/chromium.googlesource.com-external-github.com-llvm-llvm--project db3e4faa4d2cadf204e67f42bccd98957496a87a)"}
                                                                             ^~~~~~~~
```

Unfortunate choice of directory names I know .. but probably worth fixing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103108/new/

https://reviews.llvm.org/D103108



More information about the cfe-commits mailing list