[PATCH] D103184: [AArch64] handle -Wa,-march=

Fri Jun 4 13:08:20 PDT 2021

jcai19 added a comment.

In D103184#2799732 <https://reviews.llvm.org/D103184#2799732>, @nickdesaulniers wrote:

> That looks better, thanks @jcai19 .  Based on @DavidSpickett 's LGTM I think this is now ready to land.
>
> @DavidSpickett did ask:
>
>> Also please include in the commit message the "rules" that we're using here for parsing. Like I did for the arm change.
>
> So you may want to edit the commit description manually in phab if you plan to `arc patch` this in before merging, otherwise please do so locally before merging to main then pushing.

Thanks for the confirmation! I've edited the commit message to include the rules per discussed. Will wait till Monday in case @DavidSpickett has more comments.

================
Comment at: clang/test/Driver/aarch64-target-as-march.s:29
+// RUN: FileCheck --check-prefix=MULTIPLE-VALUES %s
+
+// MULTIPLE-VALUES: "-target-feature" "+v8.1a
----------------
nickdesaulniers wrote:
> jcai19 wrote:
> > DavidSpickett wrote:
> > > Add a test with `-Wa,-march=armv8.2-a,-march=armv8.1-a` (one -Wa with multiple values attached), then repeat the two tests but with `-Xassembler` instead.
> > I added a test case for -Xassembler -march=armv8.2-a,-march=armv8.1-a,  but it seems it does not support multiple values in one invocation?
> > 
> > clang --target=aarch64-linux-gnueabi -Xassembler -march=armv8.2-a,-march=armv8.1-a -c foo.s -o ias.o -###
> > ...
> > clang-13: error: the clang compiler does not support '-Xassembler -march=armv8.2-a,-march=armv8.1-a'
> > ...
> I don't think @DavidSpickett meant more `UNUSED-WARNING` tests, but tests that check the actual chosen value.
That makes more sense. Sorry for the noise.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103184/new/

https://reviews.llvm.org/D103184