[PATCH] D103615: [Clang] Add option for vector compare compatibility.

[Bardia Mahjour via Phabricator via cfe-commits]

bmahjour added a comment.

As far as I can see, there is no good reason for the special treatment of vector bool/pixel going forward. Could we drop this special treatment, or at least change the default to use a scalar results across the board (consistent with XL's behaviour and clang's current behaviour for most cases).



================
Comment at: clang/include/clang/Driver/Options.td:3811
   MarshallingInfoFlag<HeaderSearchOpts<"Verbose">>;
+def vector_abi_compat : Joined<["-"], "vector-abi-compat=">, Flags<[CC1Option]>, Group<f_Group>,
+  HelpText<"Determines whether vector compare returns a vector or a scalar. Options: default, gcc, xl.">,
----------------
I'm not sure the term "ABI" is really applicable. Maybe we should call it "vector-compare-compat="


================
Comment at: clang/test/CodeGen/vector-compat-pixel-bool-ternary.c:6
+// RUN:   -vector-abi-compat=gcc -triple powerpc-unknown-unknown -S -emit-llvm %s -o - 2>&1| FileCheck %s --check-prefix=ERROR
+// RUN: %clang_cc1 -target-feature +altivec -target-feature +vsx \
+// RUN:   -vector-abi-compat=xl -triple powerpc-unknown-unknown -S -emit-llvm %s -o - | FileCheck %s
----------------
I only see the clang FE interface being tested. Does this have to be specified through `-Xclang -vector-abi-compat=...` or is there a clang driver option for it as well? I think we should have a clang driver option and have at least one test for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103615/new/

https://reviews.llvm.org/D103615