[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

@vsk Do you mind investigating macOS `Posix/instrprof-dynamic-one-shared.test` and `Posix/instrprof-dynamic-two-shared.test` failures on https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8845381350758503248/+/steps/package_clang/0/stdout ? :) I don't have a macOS machine.

I think the only behavior change for macOS is this block:

  // Data variables can be private if not referenced by code.
  if (!DataReferencedByCode) {
    Linkage = GlobalValue::PrivateLinkage;
    Visibility = GlobalValue::DefaultVisibility;
  }

If not easy to fix, I'll just exclude isOSBinFormatMachO() for now...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103372/new/

https://reviews.llvm.org/D103372