[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 4 07:02:06 PDT 2021


martong added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:550-551
+  if (isUselessSugar(LType.getTypePtr())) {
+    LLVM_DEBUG(llvm::dbgs()
+               << "--- calculateMixability. LHS is useless sugar.\n");
     return calculateMixability(Check, LType.getSingleStepDesugaredType(Ctx),
----------------
Is this still WIP or do you use the DEBUG printouts in the tests? If not then could you please create a Diff without the DEBUG printouts, that could increase readability and ease the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75041/new/

https://reviews.llvm.org/D75041



More information about the cfe-commits mailing list