[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 4 02:22:45 PDT 2021


azabaznov added a comment.

In D102853#2773890 <https://reviews.llvm.org/D102853#2773890>, @Anastasia wrote:

> LGTM! Although I think it would be better if we set `__IMAGE_SUPPORT__` conditionally also for earlier OpenCL versions.

It has always been defined for SPIR target only. Should we wait for spec fix before merging this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102853/new/

https://reviews.llvm.org/D102853



More information about the cfe-commits mailing list