[PATCH] D103667: [WIP] BPF: add support for DWARF_AT_LLVM_annotations attribute

[David Blaikie via Phabricator via cfe-commits]

dblaikie added subscribers: JDevlieghere, probinson, aprantl.
dblaikie added a comment.

Is the C source syntax already fixed? Could it use a more specific name - then maybe wouldn't need the flag to opt-in if the only places the attribute appears is where it should be propagated?

This'll end up being broken down into many smaller patches (IR+LangRef+Bitcode support for each attribute separately, ideally, I think, for instance - separate patches for frontend generation and backend use in DWARF emission).

Probably worth an llvm-dev thread with the usual suspects (@probinson @aprantl @JDevlieghere and myself at least) - laying out the IR changes and DWARF changes (the name of the new attribute, the DIEs it'll appear on).

One thing that might be worth hashing out is whether this is DW_AT_LLVM or DW_AT_BTF (or BPF, not sure which one applies here) - whether it should be general for other uses. Given how opaque it is, I'm sort of hesitant to suggest it has a really general use - then it gets really fuzzy who's using it for what, what format it has, how to interpret it, etc. So I'd sort of be inclined towards naming it something BPF-specific, for instance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103667/new/

https://reviews.llvm.org/D103667