[PATCH] D103524: [clang][deps] Handle precompiled headers' AST files

[Michael Spencer via Phabricator via cfe-commits]

Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.

lgtm.



================
Comment at: clang/test/ClangScanDeps/modules-pch.c:7
 // RUN: %clang -x c-header %t/pch.h -fmodules -gmodules -fimplicit-module-maps \
-// RUN:   -fmodules-cache-path=%t/cache -o %t/pch.h.gch
+// RUN:   -fmodules-cache-path=%t/cache -o %t/pch.h.gch -fno-implicit-modules -fno-implicit-module-maps
 
----------------
Is this needed for this commit?


================
Comment at: clang/test/ClangScanDeps/modules-pch.c:14
 // RUN: clang-scan-deps -compilation-database %t/cdb_tu.json -format experimental-full \
-// RUN:   -generate-modules-path-args -build-dir %t/build
+// RUN:   -generate-modules-path-args -build-dir %t/build -mode preprocess >> %t/result_tu.json
+// RUN: cat %t/result_tu.json | FileCheck %s -check-prefix=CHECK-TU
----------------
You should mention that PCHs don't work with minimization yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103524/new/

https://reviews.llvm.org/D103524