[PATCH] D103452: [clang] Fix reading long doubles with va_arg on x86_64 mingw
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 3 09:24:31 PDT 2021
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clang/test/CodeGen/mingw-long-double.c:56-58
+ // GNU32: bitcast i8* %argp.cur to x86_fp80*
+ // GNU64: bitcast i8* %argp.cur to x86_fp80**
+ // MSC64: bitcast i8* %argp.cur to double*
----------------
These tests will stop working after opaque pointers happens, which I hope comes in the next year. If you look for a load of the pointer type, that should be resilient to opaque pointers.
================
Comment at: clang/test/CodeGen/win64-i128.c:25
+ // GNU64: bitcast i8* %argp.cur to i128**
+ // MSC64: bitcast i8* %argp.cur to i128**
+ __builtin_va_end(ap);
----------------
ditto
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103452/new/
https://reviews.llvm.org/D103452
More information about the cfe-commits
mailing list