[PATCH] D103519: [clang][deps] Support object files
Michael Spencer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 3 09:14:13 PDT 2021
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:161-162
+ std::make_unique<ObjectFilePCHContainerReader>());
+ PCHContainerOps->registerWriter(
+ std::make_unique<ObjectFilePCHContainerWriter>());
+
----------------
This should have a comment that we don't actually write out any PCHs, but this is still needed due to how things are currently implemented.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103519/new/
https://reviews.llvm.org/D103519
More information about the cfe-commits
mailing list