[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

Deep Majumder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 3 03:39:42 PDT 2021


RedDocMD added a comment.

In D103434#2795940 <https://reviews.llvm.org/D103434#2795940>, @vsavchenko wrote:

> I was thinking a lot about this problem after our last call, and even though `StoppableVisitor` helps to solve the problem that we have, it is extremely unclear when this callback is called and should be called.
> I decided to restore the balance (and rid of all younglings, maybe) and put together this interface: D103605 <https://reviews.llvm.org/D103605>.  I still need to migrate the existing code into the new architecture, but it can be done incrementally.

Right. I then perhaps should focus now on D98726 <https://reviews.llvm.org/D98726>, and then return to `GetNoteEmitter`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103434/new/

https://reviews.llvm.org/D103434



More information about the cfe-commits mailing list