[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

[Petr Hosek via Phabricator via cfe-commits]

phosek added a comment.

`OpenMP/tile_codegen_tile_for.cpp` is failing on all our bots, would it be possible to revert the change?

  FAIL: Clang :: OpenMP/tile_codegen_tile_for.cpp (9951 of 28034)
  ******************** TEST 'Clang :: OpenMP/tile_codegen_tile_for.cpp' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/s/w/ir/x/w/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -verify -triple x86_64-pc-linux-gnu -fopenmp -fopenmp-version=51 -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp -o - | /opt/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --allow-unused-prefixes /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp --check-prefix=IR
  : 'RUN: at line 5';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/s/w/ir/x/w/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -verify -triple x86_64-pc-linux-gnu -fopenmp -fopenmp-version=51 -emit-pch -o /opt/s/w/ir/x/w/staging/llvm_build/tools/clang/test/OpenMP/Output/tile_codegen_tile_for.cpp.tmp /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp
  : 'RUN: at line 6';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal-isystem /opt/s/w/ir/x/w/staging/llvm_build/lib/clang/13.0.0/include -nostdsysteminc -verify -triple x86_64-pc-linux-gnu -fopenmp -fopenmp-version=51 -include-pch /opt/s/w/ir/x/w/staging/llvm_build/tools/clang/test/OpenMP/Output/tile_codegen_tile_for.cpp.tmp -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp -o - | /opt/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --allow-unused-prefixes /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp --check-prefix=IR
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp:250:8: error: IR: expected string not found in input
  // IR: ![[META1:[0-9]+]] = !{!"clang version {{[^"]*}}"}
         ^
  <stdin>:260:36: note: scanning from here
  !0 = !{i32 1, !"wchar_size", i32 4}
                                     ^
  <stdin>:261:1: note: possible intended match here
  !1 = !{!"Fuchsia clang version 13.0.0 (https://llvm.googlesource.com/a/llvm-project 07a6beb402150d25ec7c93a5747520ac2804731d)"}
  ^
  
  Input file: <stdin>
  Check file: /opt/s/w/ir/x/w/llvm-project/clang/test/OpenMP/tile_codegen_tile_for.cpp
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
               .
               .
               .
             255: attributes #2 = { convergent nounwind } 
             256:  
             257: !llvm.module.flags = !{!0} 
             258: !llvm.ident = !{!1} 
             259:  
             260: !0 = !{i32 1, !"wchar_size", i32 4} 
  check:250'0                                        X error: no match found
             261: !1 = !{!"Fuchsia clang version 13.0.0 (https://llvm.googlesource.com/a/llvm-project 07a6beb402150d25ec7c93a5747520ac2804731d)"} 
  check:250'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  check:250'1     ?                                                                                                                                possible intended match
             262: !2 = distinct !{!2, !3} 
  check:250'0     ~~~~~~~~~~~~~~~~~~~~~~~~
             263: !3 = !{!"llvm.loop.mustprogress"} 
  check:250'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             264: !4 = distinct !{!4, !3} 
  check:250'0     ~~~~~~~~~~~~~~~~~~~~~~~~
  >>>>>>
  
  --
  
  ********************


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102180/new/

https://reviews.llvm.org/D102180