[PATCH] D103564: [NFC][compiler-rt][hwasan] Wrap vfork interceptor with HWASAN_WITH_INTERCEPTORS
Evgenii Stepanov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 2 16:05:47 PDT 2021
eugenis added a comment.
s/vfork/fork/ in the description
I'm afraid removing the fork interceptor will break Android. This is a pretty uncommon condition, but still. It is interesting to note that ASan does not have this fork protection, see https://github.com/google/sanitizers/issues/774 for some history.
I wonder if this could be replaced with pthread_atfork. The order of callback execution seems right, as long as hwasan is registered first. Or, if you want to make progress, add SANITIZER_ANDROID ifdef somewhere.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103564/new/
https://reviews.llvm.org/D103564
More information about the cfe-commits
mailing list