[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM.

---

A little bit thinking out loud, was there a particular reason to introduce `--check-line` into ClangdMain.cpp rather than Check.cpp?

It feels like we should have --check related flags in Check.cpp instead. That way both the signature of `check` stays more reasonable and ClangdMain won't accumulate `flag to internal value` logic.



================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:66
+           const ThreadsafeFS &TFS, const ClangdLSPServer::Options &Opts,
+           const bool EnableCodeCompletion);
 
----------------
nit: it is not common to have const on params that are copied (especially when they are just builtins)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103538/new/

https://reviews.llvm.org/D103538