[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 1 12:57:22 PDT 2021


aaron.ballman added a comment.

In D103485#2791940 <https://reviews.llvm.org/D103485#2791940>, @erichkeane wrote:

> The patch looks fine to me, though I don't particularly get the test changes that move a diagnostic by 1 line?

The `global-vs-module.cpp` test had a line removed from it for the `FIXME` comment. The `module-vs-module.cpp` and `module-vs-global.cpp` files both reference diagnostics by line within `global-vs-module.cpp`, so those lines all had to be adjusted accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103485/new/

https://reviews.llvm.org/D103485



More information about the cfe-commits mailing list