[PATCH] D103461: [clang][deps] NFC: Do not adjust the original action

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 1 12:12:31 PDT 2021


dexonsmith added a comment.

Is there (or could there be) a mode where `clang-scan-deps` prints out the command-lines it sends to the dependency scanning action (maybe instead of actually scanning), so this could be tested?



================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:442-443
   ResourceDirectoryCache ResourceDirCache;
+  // FIXME: Adjust the resulting CompilerInvocation in DependencyScanningAction
+  //  instead of parsing and adjusting the raw command-line.
   AdjustingCompilations->appendArgumentsAdjuster(
----------------
Nit: blank line before the comment might make it easier to read; also the second line seems to have an indent, is that intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103461/new/

https://reviews.llvm.org/D103461



More information about the cfe-commits mailing list