[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added a comment.

> I also added a new test file to check the output AST. If there's a better place for this test I will move it there.

If you're primarily interested in the AST, then it doesn't have to be a Sema test I guess.  In that case `clang/test/AST` seems to be a better place, and you could also remove the `-verify` parts of the test perhaps (unless you think it adds value that isn't tested elsewhere)?



================
Comment at: clang/test/SemaOpenCLCXX/addrspace-assignment.clcpp:10
+// expected-note at +1{{candidate function (the implicit move assignment operator) not viable: no known conversion from 'int' to '__generic Implicit' for 1st argument}}
+struct Implicit {};
+
----------------
Maybe rename this struct to avoid any potential confusion with the `implicit` keyword in the dumps above?  Even something as simple as `S` should do I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103252/new/

https://reviews.llvm.org/D103252