[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 31 13:12:36 PDT 2021


ldionne added a comment.

In D91630#2787438 <https://reviews.llvm.org/D91630#2787438>, @thakis wrote:

> This is breaking check-clang everywhere, eg https://lab.llvm.org/buildbot/#/builders/109/builds/15757
>
> Please run tests before landing, or failing that watch the bots after committing.
>
> Reverted in f63adf5b67f7a25b15f81d3a1a207aba4f226dc4 <https://reviews.llvm.org/rGf63adf5b67f7a25b15f81d3a1a207aba4f226dc4> for now.

Sorry about that, I thought the pre-commit CI here on Phabricator had passed those tests successfully. The only failures I was seeing were related to `clang-format`. I'm not sure what happened. Anyway, thanks for reverting, I'll take a look at this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91630/new/

https://reviews.llvm.org/D91630



More information about the cfe-commits mailing list